public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: /, lib/portage/package/ebuild/
Date: Sat, 11 Nov 2023 02:55:31 +0000 (UTC)	[thread overview]
Message-ID: <1699671328.49c573054764768a51a4764c6e642b038c8e55d4.sam@gentoo> (raw)

commit:     49c573054764768a51a4764c6e642b038c8e55d4
Author:     wh0 <wh0 <AT> users <DOT> noreply <DOT> github <DOT> com>
AuthorDate: Mon Nov  6 17:39:50 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sat Nov 11 02:55:28 2023 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=49c57305

ebuild: add some missing newlines in errors

Closes: https://github.com/gentoo/portage/pull/1177
Signed-off-by: Sam James <sam <AT> gentoo.org>

 NEWS                                 | 3 +++
 lib/portage/package/ebuild/config.py | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 1e589c1f8d..362266369f 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,9 @@ portage-3.0.56 (UNRELEASED)
 Features:
 * sync: git: Add sync-git-verify-max-age-days option.
 
+Bug fixes:
+* ebuild: Add missing newlines in error messages.
+
 portage-3.0.55 (2023-11-06)
 --------------
 

diff --git a/lib/portage/package/ebuild/config.py b/lib/portage/package/ebuild/config.py
index f51886c33e..8a57e0c145 100644
--- a/lib/portage/package/ebuild/config.py
+++ b/lib/portage/package/ebuild/config.py
@@ -1565,7 +1565,7 @@ class config:
             except KeyError as e:
                 writemsg(
                     "!!! BINPKG_COMPRESS contains invalid or "
-                    "unsupported compression method: %s" % e.args[0],
+                    "unsupported compression method: %s\n" % e.args[0],
                     noiselevel=-1,
                 )
             else:
@@ -1587,7 +1587,7 @@ class config:
                 except IndexError as e:
                     writemsg(
                         "!!! BINPKG_COMPRESS contains invalid or "
-                        "unsupported compression method: %s" % e.args[0],
+                        "unsupported compression method: %s\n" % e.args[0],
                         noiselevel=-1,
                     )
                 else:
@@ -1595,7 +1595,7 @@ class config:
                         missing_package = compression["package"]
                         writemsg(
                             "!!! BINPKG_COMPRESS unsupported %s. "
-                            "Missing package: %s"
+                            "Missing package: %s\n"
                             % (binpkg_compression, missing_package),
                             noiselevel=-1,
                         )


                 reply	other threads:[~2023-11-11  2:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1699671328.49c573054764768a51a4764c6e642b038c8e55d4.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox