public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-libs/rocr-runtime/
Date: Wed,  8 Feb 2023 04:18:08 +0000 (UTC)	[thread overview]
Message-ID: <1675829856.526eb8d42a4ff112e1e3b0f8aee4ae57778f66d6.sam@gentoo> (raw)

commit:     526eb8d42a4ff112e1e3b0f8aee4ae57778f66d6
Author:     Yiyang Wu <xgreenlandforwyy <AT> gmail <DOT> com>
AuthorDate: Wed Feb  8 02:38:50 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Feb  8 04:17:36 2023 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=526eb8d4

dev-libs/rocr-runtime: NDEBUG by default; add debug use flag

The rocr-runtime relies on -DNDEBUG cxxflag to build without debug code.
Previously debug codes are turned on and issues are observed by users.

Reference: https://github.com/RadeonOpenCompute/ROCm/issues/1880#issuecomment-1416759759
Signed-off-by: Yiyang Wu <xgreenlandforwyy <AT> gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/29297
Signed-off-by: Sam James <sam <AT> gentoo.org>

 .../{rocr-runtime-5.3.3.ebuild => rocr-runtime-5.3.3-r1.ebuild}     | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/dev-libs/rocr-runtime/rocr-runtime-5.3.3.ebuild b/dev-libs/rocr-runtime/rocr-runtime-5.3.3-r1.ebuild
similarity index 94%
rename from dev-libs/rocr-runtime/rocr-runtime-5.3.3.ebuild
rename to dev-libs/rocr-runtime/rocr-runtime-5.3.3-r1.ebuild
index 99184725f576..f408d4213314 100644
--- a/dev-libs/rocr-runtime/rocr-runtime-5.3.3.ebuild
+++ b/dev-libs/rocr-runtime/rocr-runtime-5.3.3-r1.ebuild
@@ -3,7 +3,7 @@
 
 EAPI=8
 
-inherit cmake llvm
+inherit cmake flag-o-matic llvm
 
 LLVM_MAX_SLOT=15
 
@@ -25,6 +25,7 @@ PATCHES=(
 
 LICENSE="MIT"
 SLOT="0/$(ver_cut 1-2)"
+IUSE="debug"
 
 COMMON_DEPEND="dev-libs/elfutils"
 RDEPEND="${COMMON_DEPEND}"
@@ -36,8 +37,6 @@ DEPEND="${COMMON_DEPEND}
 BDEPEND="app-editors/vim-core"
 	# vim-core is needed for "xxd"
 
-CMAKE_BUILD_TYPE=Release
-
 src_prepare() {
 	# ... otherwise system llvm/clang is used ...
 	sed -e "/find_package(Clang REQUIRED HINTS /s:\${CMAKE_INSTALL_PREFIX}/llvm \${CMAKE_PREFIX_PATH}/llvm PATHS /opt/rocm/llvm:$(get_llvm_prefix ${LLVM_MAX_SLOT}):" -i image/blit_src/CMakeLists.txt || die
@@ -49,6 +48,7 @@ src_prepare() {
 }
 
 src_configure() {
+	use debug || append-cxxflags "-DNDEBUG"
 	local mycmakeargs=( -DINCLUDE_PATH_COMPATIBILITY=OFF )
 	cmake_src_configure
 }


             reply	other threads:[~2023-02-08  4:18 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08  4:18 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-11 18:14 [gentoo-commits] repo/gentoo:master commit in: dev-libs/rocr-runtime/ Andreas Sturmlechner
2025-06-30  6:09 Ionen Wolkens
2025-06-15 16:12 Sam James
2024-12-01  7:57 Patrick Lauer
2024-07-28  8:00 Patrick Lauer
2024-03-12  2:25 Sam James
2024-03-12  2:25 Sam James
2024-03-12  2:25 Sam James
2024-03-08 19:26 Sam James
2023-12-23 16:10 罗百科
2023-12-23 10:43 罗百科
2023-10-24  8:12 罗百科
2023-10-19 10:38 罗百科
2023-10-09 12:34 罗百科
2023-09-03  6:31 罗百科
2023-03-02  8:53 罗百科
2023-02-22 16:16 Sam James
2023-02-08  4:18 Sam James
2023-02-01  9:53 Andreas Sturmlechner
2022-12-20  9:26 罗百科
2022-11-19 11:50 Benda XU
2022-08-06 14:23 Benda XU
2022-06-22 13:21 Benda XU
2021-08-19 19:46 Craig Andrews
2021-07-11  3:26 Craig Andrews
2021-06-28 20:05 Craig Andrews
2021-04-27 13:16 Craig Andrews
2021-04-08 19:18 Craig Andrews
2020-12-21 12:55 Craig Andrews
2020-12-06 19:04 Craig Andrews
2020-11-15 12:43 Craig Andrews
2020-11-13 21:07 Craig Andrews
2020-09-20 21:01 Craig Andrews
2020-09-20 20:54 Craig Andrews
2020-09-20 20:54 Craig Andrews
2020-09-08 16:22 Craig Andrews
2020-08-25 21:08 Craig Andrews
2020-08-22 17:49 Craig Andrews
2020-04-01 19:33 Craig Andrews
2020-03-02  0:39 Craig Andrews
2020-02-29  4:36 Craig Andrews
2020-01-02 12:59 Craig Andrews
2019-11-24 17:10 Craig Andrews
2019-10-05 14:32 Craig Andrews
2019-09-30 15:23 Craig Andrews
2019-08-20 18:25 Craig Andrews
2019-08-14 20:54 Craig Andrews
2019-08-07 17:38 Craig Andrews
2019-08-07 17:38 Craig Andrews

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1675829856.526eb8d42a4ff112e1e3b0f8aee4ae57778f66d6.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox