public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/elfix:master commit in: misc/fix-gnustack/tests/
Date: Wed, 11 Jan 2023 07:54:39 +0000 (UTC)	[thread overview]
Message-ID: <1673421367.c8a1d365ff1349cc438352917863ed98ee34a80f.sam@gentoo> (raw)

commit:     c8a1d365ff1349cc438352917863ed98ee34a80f
Author:     Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Wed Jan 11 07:09:53 2023 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Wed Jan 11 07:16:07 2023 +0000
URL:        https://gitweb.gentoo.org/proj/elfix.git/commit/?id=c8a1d365

fix-gnustack: pass -Wl,-z,execstack for tests with Clang

Clang doesn't create executable stacks by default, so we need to force it
for the purposes of the tests.

Signed-off-by: Sam James <sam <AT> gentoo.org>

 misc/fix-gnustack/tests/Makefile.am | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/misc/fix-gnustack/tests/Makefile.am b/misc/fix-gnustack/tests/Makefile.am
index ad573a3..17bec0d 100644
--- a/misc/fix-gnustack/tests/Makefile.am
+++ b/misc/fix-gnustack/tests/Makefile.am
@@ -8,8 +8,10 @@ bad-gnustack.s: bad-gnustack.c
 	$(CC) $(CPPFLAGS) $(CFLAGS) -S $<
 	$(SED) -i -e 's/GNU-stack,"",/GNU-stack,"x",/' $@
 
+# Clang doesn't create executable stacks by default, so
+# tests for fix-gnustack fail without this.
 bad-gnustack$(EXEEXT): bad-gnustack.s
-	$(CC) $(CFLAGS) $(LDFLAGS) -o $@ $<
+	$(CC) $(CFLAGS) $(LDFLAGS) -Wl,-z,execstack -o $@ $<
 
 check_SCRIPTS = gnustacktest
 TEST = $(check_SCRIPTS)


             reply	other threads:[~2023-01-11  7:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  7:54 Sam James [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-10  5:21 [gentoo-commits] proj/elfix:master commit in: misc/fix-gnustack/tests/ Sam James
2023-01-10  5:21 Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1673421367.c8a1d365ff1349cc438352917863ed98ee34a80f.sam@gentoo \
    --to=sam@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox