From: "Ionen Wolkens" <ionen@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtwebengine/, dev-qt/qtwebengine/files/
Date: Wed, 17 Aug 2022 21:20:12 +0000 (UTC) [thread overview]
Message-ID: <1660771160.86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac.ionen@gentoo> (raw)
commit: 86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac
Author: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
AuthorDate: Wed Aug 17 18:32:03 2022 +0000
Commit: Ionen Wolkens <ionen <AT> gentoo <DOT> org>
CommitDate: Wed Aug 17 21:19:20 2022 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=86ee2059
dev-qt/qtwebengine: backport :6 favicon display fix
Not worth a revbump rebuild, but is still annoying and
wanted to toss it here at least for future builds.
Signed-off-by: Ionen Wolkens <ionen <AT> gentoo.org>
.../files/qtwebengine-6.3.1-favicon.patch | 28 ++++++++++++++++++++++
dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild | 1 +
2 files changed, 29 insertions(+)
diff --git a/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch b/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch
new file mode 100644
index 000000000000..8c9544b16935
--- /dev/null
+++ b/dev-qt/qtwebengine/files/qtwebengine-6.3.1-favicon.patch
@@ -0,0 +1,28 @@
+Backport dev branch fix for favicons sometime not showing in
+some consumers like qutebrowser. Not currently included in
+upcoming 6.3.2 so may be needed beyond 6.3.1.
+
+https://bugreports.qt.io/browse/QTBUG-103735
+https://github.com/qt/qtwebengine/commit/c5de1b2123
+--- a/src/core/favicon_driver_qt.cpp
++++ b/src/core/favicon_driver_qt.cpp
+@@ -300,15 +300,15 @@ void FaviconDriverQt::DidStartNavigation(content::NavigationHandle *navigation_h
+ return;
+
+ m_faviconUrls.reset();
+- m_completedHandlersCount = 0;
+- m_latestFavicon = FaviconStatusQt();
+
+ if (!navigation_handle->IsSameDocument()) {
++ m_completedHandlersCount = 0;
++ m_latestFavicon = FaviconStatusQt();
+ m_documentOnLoadCompleted = false;
+ m_manifestUrl = GURL();
+- }
+
+- m_viewClient->iconChanged(QUrl());
++ m_viewClient->iconChanged(QUrl());
++ }
+
+ content::ReloadType reload_type = navigation_handle->GetReloadType();
+ if (reload_type == content::ReloadType::NONE || IsOffTheRecord())
diff --git a/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild b/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild
index 468f7bbc29d7..91f14a1f75cf 100644
--- a/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild
+++ b/dev-qt/qtwebengine/qtwebengine-6.3.1.ebuild
@@ -88,6 +88,7 @@ DEPEND="${RDEPEND}
PATCHES=(
"${FILESDIR}"/${P}-widevine.patch
+ "${FILESDIR}"/${P}-favicon.patch
)
python_check_deps() {
next reply other threads:[~2022-08-17 21:20 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 21:20 Ionen Wolkens [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-28 6:53 [gentoo-commits] repo/gentoo:master commit in: dev-qt/qtwebengine/, dev-qt/qtwebengine/files/ Ionen Wolkens
2025-09-09 10:30 Ionen Wolkens
2025-07-10 14:33 Ionen Wolkens
2025-06-05 8:46 Ionen Wolkens
2025-04-06 14:48 Ionen Wolkens
2025-04-02 5:09 Ionen Wolkens
2025-03-30 15:04 Ionen Wolkens
2025-02-26 8:47 Ionen Wolkens
2025-02-13 19:49 Ionen Wolkens
2025-01-06 22:51 Ionen Wolkens
2025-01-04 4:05 Ionen Wolkens
2024-12-28 16:58 Andreas Sturmlechner
2024-12-03 17:15 Ionen Wolkens
2024-11-23 8:44 Andreas Sturmlechner
2024-10-21 12:31 Sam James
2024-08-14 15:37 Ionen Wolkens
2024-07-28 4:30 Sam James
2024-07-03 0:39 Ionen Wolkens
2024-06-08 13:41 Ionen Wolkens
2024-05-30 12:52 Andreas Sturmlechner
2024-04-19 7:55 Ionen Wolkens
2024-04-17 0:15 Ionen Wolkens
2024-04-03 3:57 Ionen Wolkens
2024-03-22 10:29 Ionen Wolkens
2024-02-25 18:46 Ionen Wolkens
2024-02-01 23:06 Andreas Sturmlechner
2024-01-16 11:53 Andreas Sturmlechner
2024-01-03 19:10 Ionen Wolkens
2023-12-18 18:43 Ionen Wolkens
2023-11-20 13:44 Ionen Wolkens
2023-10-05 19:39 Ionen Wolkens
2023-09-07 10:03 Ionen Wolkens
2023-05-24 11:15 Andreas Sturmlechner
2023-04-25 15:38 Andreas Sturmlechner
2023-04-17 19:39 Jimi Huotari
2023-04-15 2:10 Sam James
2023-04-09 20:17 Andreas Sturmlechner
2022-09-24 14:32 Andreas Sturmlechner
2022-06-20 18:54 Andreas Sturmlechner
2022-05-20 19:43 Andreas Sturmlechner
2022-05-14 21:24 Sam James
2022-04-17 19:29 Sam James
2022-04-09 16:07 Andreas Sturmlechner
2021-10-17 6:54 Andreas Sturmlechner
2021-09-02 18:38 Andreas Sturmlechner
2021-09-02 18:38 Andreas Sturmlechner
2021-06-14 9:25 Andreas Sturmlechner
2021-05-23 19:19 Andreas Sturmlechner
2021-03-24 12:15 Andreas Sturmlechner
2020-04-26 18:12 Andreas Sturmlechner
2020-03-22 14:40 Andreas Sturmlechner
2020-02-10 6:42 Andreas Sturmlechner
2020-02-08 21:34 Andreas Sturmlechner
2019-10-20 14:21 Andreas Sturmlechner
2019-09-25 21:34 Andreas Sturmlechner
2019-09-01 23:07 Andreas Sturmlechner
2018-11-10 20:27 Andreas Sturmlechner
2018-05-09 20:17 Andreas Sturmlechner
2017-12-05 11:21 Michael Palimaka
2017-06-04 13:19 Michael Palimaka
2016-12-06 6:54 Michael Palimaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1660771160.86ee2059ef3322c2f01aaeac896b1d8a2ccb51ac.ionen@gentoo \
--to=ionen@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox