From: "Sam James" <sam@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: dev-vcs/hub/
Date: Fri, 28 May 2021 20:14:33 +0000 (UTC) [thread overview]
Message-ID: <1622232834.050d2bc17789f3ee1a09b01c20b2cfca774034f2.sam@gentoo> (raw)
commit: 050d2bc17789f3ee1a09b01c20b2cfca774034f2
Author: Sam James <sam <AT> gentoo <DOT> org>
AuthorDate: Fri Apr 2 12:02:06 2021 +0000
Commit: Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Fri May 28 20:13:54 2021 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=050d2bc1
dev-vcs/hub: use vendored modules, not from network(!)
On platforms without network-sandbox (or with it disabled),
we get:
[...]
# get https://proxy.golang.org/github.com/mitchellh/go-homedir/ <AT> v/v0.0.0-20161203194507-b8bc1bf76747.mod: 200 OK (0.229s)
# get https://proxy.golang.org/gopkg.in/yaml.v2/ <AT> v/v2.0.0-20190319135612-7b8349ac747c.mod: 200 OK (0.230s)
# get https://proxy.golang.org/github.com/russross/blackfriday/ <AT> v/v0.0.0-20180526075726-670777b536d3.mod: 200 OK (0.229s)
[...]
We need to explicitly re-give the upstream default for their
GOFLAGS as our default in the eclass is overriding it.
Signed-off-by: Sam James <sam <AT> gentoo.org>
dev-vcs/hub/{hub-2.14.2.ebuild => hub-2.14.2-r1.ebuild} | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/dev-vcs/hub/hub-2.14.2.ebuild b/dev-vcs/hub/hub-2.14.2-r1.ebuild
similarity index 69%
rename from dev-vcs/hub/hub-2.14.2.ebuild
rename to dev-vcs/hub/hub-2.14.2-r1.ebuild
index 6f811000511..ca4e205866a 100644
--- a/dev-vcs/hub/hub-2.14.2.ebuild
+++ b/dev-vcs/hub/hub-2.14.2-r1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2021 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2
EAPI=7
@@ -16,6 +16,11 @@ KEYWORDS="~amd64 ~ppc64 ~x86 ~amd64-linux ~x86-linux"
RDEPEND=">=dev-vcs/git-1.7.3"
src_compile() {
+ # The eclass setting GOFLAGS at all overrides this default
+ # in the upstream Makefile. It'll *FALL BACK* to bundled/vendored
+ # modules but without this, it'll try fetching. On platforms
+ # without network-sandbox (or relying on it), this is not okay.
+ export GOFLAGS="${GOFLAGS} -mod=vendor"
emake bin/hub man-pages
}
next reply other threads:[~2021-05-28 20:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 20:14 Sam James [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-05-28 20:14 [gentoo-commits] repo/gentoo:master commit in: dev-vcs/hub/ Sam James
2021-05-28 20:14 Sam James
2021-02-15 21:02 William Hubbs
2020-06-14 17:43 William Hubbs
2020-05-26 6:07 Georgy Yakovlev
2020-03-18 0:44 William Hubbs
2020-02-17 2:39 William Hubbs
2020-01-01 15:09 William Hubbs
2019-11-25 17:26 William Hubbs
2019-11-25 16:17 William Hubbs
2019-07-25 14:22 William Hubbs
2019-07-25 14:12 William Hubbs
2019-04-13 20:52 William Hubbs
2019-03-16 1:37 William Hubbs
2019-02-28 0:14 William Hubbs
2019-01-21 22:46 William Hubbs
2019-01-15 18:07 William Hubbs
2019-01-01 17:35 William Hubbs
2018-12-26 22:18 William Hubbs
2018-12-26 18:56 William Hubbs
2016-11-16 2:17 Christoph Junghans
2016-08-06 16:51 Michał Górny
2016-03-13 0:09 Christoph Junghans
2016-01-22 18:48 Justin Lecher
2015-10-31 9:00 Justin Lecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622232834.050d2bc17789f3ee1a09b01c20b2cfca774034f2.sam@gentoo \
--to=sam@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox