From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/devmanual:master commit in: quickstart/
Date: Mon, 13 May 2019 18:52:11 +0000 (UTC) [thread overview]
Message-ID: <1557773422.858a4bf9eb22523b936651861d74780843d68f19.ulm@gentoo> (raw)
commit: 858a4bf9eb22523b936651861d74780843d68f19
Author: Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Mon Apr 22 07:22:44 2019 +0000
Commit: Ulrich Müller <ulm <AT> gentoo <DOT> org>
CommitDate: Mon May 13 18:50:22 2019 +0000
URL: https://gitweb.gentoo.org/proj/devmanual.git/commit/?id=858a4bf9
quickstart: Remove unnecessary src_install() from most examples
Remove most of src_install() redefinitions since they completely match
the default. Leave the initial one for demonstration purposes,
and the last one since it is more complex.
Signed-off-by: Michał Górny <mgorny <AT> gentoo.org>
Signed-off-by: Ulrich Müller <ulm <AT> gentoo.org>
quickstart/text.xml | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)
diff --git a/quickstart/text.xml b/quickstart/text.xml
index 51f9962..d913374 100644
--- a/quickstart/text.xml
+++ b/quickstart/text.xml
@@ -225,11 +225,6 @@ DEPEND="${RDEPEND}
src_configure() {
econf --with-popt
}
-
-src_install() {
- emake DESTDIR="${D}" install
- dodoc README CHANGES
-}
</codesample>
<p>
@@ -241,7 +236,9 @@ variables <d/> see
</p>
<p>
-Again, we define <c>src_configure</c> and <c>src_install</c> functions.
+We define <c>src_configure</c> only. <c>src_install</c> does not need to
+be defined since the default implementation calling <c>emake install</c>
+and installing common documentation files works correctly for the package.
</p>
<p>
@@ -291,11 +288,6 @@ src_prepare() {
src_configure() {
econf --with-popt
}
-
-src_install() {
- emake DESTDIR="${D}" install
- dodoc README CHANGES
-}
</codesample>
<p>
@@ -339,10 +331,6 @@ DEPEND="!sys-libs/glibc"
src_configure() {
econf $(use_enable nls)
}
-
-src_install() {
- emake DESTDIR="${D}" install
-}
</codesample>
<p>
next reply other threads:[~2019-05-13 18:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 18:52 Ulrich Müller [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-18 2:07 [gentoo-commits] proj/devmanual:master commit in: quickstart/ Sam James
2022-03-13 1:47 Sam James
2021-12-09 4:12 Sam James
2021-12-09 4:09 Sam James
2021-12-09 4:08 Sam James
2021-12-09 4:08 Sam James
2020-02-16 18:05 Ulrich Müller
2020-01-23 13:50 Ulrich Müller
2019-11-26 3:05 Göktürk Yüksek
2019-11-26 1:49 Göktürk Yüksek
2019-05-13 18:52 Ulrich Müller
2019-05-13 18:52 Ulrich Müller
2018-10-24 17:49 Brian Evans
2018-06-14 18:43 Göktürk Yüksek
2016-10-28 14:41 Göktürk Yüksek
2015-08-09 12:39 Justin Lecher
2015-08-09 12:39 Justin Lecher
2013-01-21 8:18 Pacho Ramos
2012-10-12 17:44 Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557773422.858a4bf9eb22523b936651861d74780843d68f19.ulm@gentoo \
--to=ulm@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox