From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] repo/gentoo:master commit in: app-emulation/cri-o/
Date: Mon, 29 Apr 2019 17:34:59 +0000 (UTC) [thread overview]
Message-ID: <1556559171.a0e75219444993d81826f7650bcccad80c968b5d.zmedico@gentoo> (raw)
commit: a0e75219444993d81826f7650bcccad80c968b5d
Author: Dongsu Park <dongsu <AT> kinvolk <DOT> io>
AuthorDate: Mon Apr 29 05:42:50 2019 +0000
Commit: Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Mon Apr 29 17:32:51 2019 +0000
URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0e75219
app-emulation/cri-o: disable go build install flag
There has been a corner case where `make bin/crio` failed like that:
```
go build runtime/cgo: open /usr/lib/go1.12/pkg/linux_amd64/runtime/cgo.a: permission denied
make: *** [Makefile:99: bin/crio] Error 1
```
The failure happens only under certain circumstances, for example in
Jenkins pipelines, where the standard Go runtime path `/usr/lib/go1.12`
is not writable for normal users like `jenkins`. On the other hand, the
failure is not reproducible when testing locally, nor when testing
with the root user who can write to the Go runtime path.
What happens is, the standard Go runtime sometime has incorrect
timestamps or checksums of `cgo.a`, which makes `go build -i` think
that it has to install its own library to the system directory. That's
obviously not what the build process should do. Since Go 1.10, it's
unnecessary to run `go build` with an `-i` option, because now `go build`
command itself maintains a cache of recently build packages. Build speed
will not be better by adding an `-i` option.
So let's remove `-i` flag from `go build`. That's actually what upstream
Go maintainers recommend to do.
See: https://github.com/golang/go/issues/24674
Closes: https://github.com/gentoo/gentoo/pull/11863
Package-Manager: Portage-2.3.65, Repoman-2.3.12
Signed-off-by: Dongsu Park <dongsu <AT> kinvolk.io>
Signed-off-by: Zac Medico <zmedico <AT> gentoo.org>
app-emulation/cri-o/cri-o-1.10.6.ebuild | 2 +-
app-emulation/cri-o/cri-o-1.13.5.ebuild | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/app-emulation/cri-o/cri-o-1.10.6.ebuild b/app-emulation/cri-o/cri-o-1.10.6.ebuild
index dbb1db95a32..845da94a93b 100644
--- a/app-emulation/cri-o/cri-o-1.10.6.ebuild
+++ b/app-emulation/cri-o/cri-o-1.10.6.ebuild
@@ -43,7 +43,7 @@ src_prepare() {
default
sed -e '/^GIT_.*/d' \
- -e 's/$(GO) build/$(GO) build -v -work -x/' \
+ -e 's/$(GO) build -i/$(GO) build -v -work -x/' \
-e 's/\${GIT_COMMIT}/'${EGIT_COMMIT}'/' \
-i Makefile || die
diff --git a/app-emulation/cri-o/cri-o-1.13.5.ebuild b/app-emulation/cri-o/cri-o-1.13.5.ebuild
index bf1e755e142..2478498c2a7 100644
--- a/app-emulation/cri-o/cri-o-1.13.5.ebuild
+++ b/app-emulation/cri-o/cri-o-1.13.5.ebuild
@@ -44,7 +44,7 @@ src_prepare() {
sed -e '/^GIT_.*/d' \
-e '/ git diff --exit-code/d' \
- -e 's/$(GO) build/$(GO) build -v -work -x/' \
+ -e 's/$(GO) build -i/$(GO) build -v -work -x/' \
-e 's/\${GIT_COMMIT}/'${EGIT_COMMIT}'/' \
-i Makefile || die
next reply other threads:[~2019-04-29 17:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 17:34 Zac Medico [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-11-12 3:01 [gentoo-commits] repo/gentoo:master commit in: app-emulation/cri-o/ Zac Medico
2021-11-12 3:01 Zac Medico
2021-04-26 23:20 Zac Medico
2021-04-26 23:20 Zac Medico
2020-09-21 16:34 Zac Medico
2020-08-31 10:18 Alexis Ballier
2020-08-19 16:48 Zac Medico
2020-08-19 16:39 Zac Medico
2020-03-17 15:02 William Hubbs
2020-02-12 21:35 William Hubbs
2020-02-12 21:35 William Hubbs
2019-09-19 4:06 Zac Medico
2019-09-19 3:58 Zac Medico
2019-09-19 3:58 Zac Medico
2019-09-06 22:58 Zac Medico
2019-09-06 22:47 Zac Medico
2019-07-21 5:59 Zac Medico
2019-07-21 5:33 Zac Medico
2019-06-12 18:01 Zac Medico
2019-06-01 6:42 Zac Medico
2019-06-01 3:48 Zac Medico
2019-06-01 0:16 Zac Medico
2019-05-28 23:35 Zac Medico
2019-05-01 22:27 Zac Medico
2019-04-29 17:23 Zac Medico
2019-04-11 22:49 Zac Medico
2019-04-11 21:53 Zac Medico
2019-02-17 18:29 Zac Medico
2019-01-04 0:06 Zac Medico
2018-12-04 10:24 Zac Medico
2018-06-04 8:32 Zac Medico
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556559171.a0e75219444993d81826f7650bcccad80c968b5d.zmedico@gentoo \
--to=zmedico@gentoo.org \
--cc=gentoo-commits@lists.gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox