public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Robin H. Johnson" <robbat2@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/netifrc:master commit in: init.d/
Date: Sun, 21 Apr 2019 05:34:03 +0000 (UTC)	[thread overview]
Message-ID: <1555824731.abcc0bd4c372e36cc6e5e46832e7664a72b6bcaa.robbat2@OpenRC> (raw)

commit:     abcc0bd4c372e36cc6e5e46832e7664a72b6bcaa
Author:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
AuthorDate: Sun Apr 21 05:22:09 2019 +0000
Commit:     Robin H. Johnson <robbat2 <AT> gentoo <DOT> org>
CommitDate: Sun Apr 21 05:32:11 2019 +0000
URL:        https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=abcc0bd4

init.d/net.lo.in: shellcheck: depend()

Signed-off-by: Robin H. Johnson <robbat2 <AT> gentoo.org>

 init.d/net.lo.in | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/init.d/net.lo.in b/init.d/net.lo.in
index 6d6b581..e49278f 100644
--- a/init.d/net.lo.in
+++ b/init.d/net.lo.in
@@ -34,10 +34,11 @@ MODULESLIST="${RC_SVCDIR}/nettree$(get_interface)"
 
 depend()
 {
-	local IFACE=$(get_interface)
-	local IFVAR=$(shell_var "${IFACE}")
+	local IFACE IFVAR
+	IFACE=$(get_interface)
+	IFVAR=$(shell_var "${IFACE}")
 
-	if [ "$RC_UNAME" = Linux -a "$IFACE" != lo ]; then
+	if [ "$RC_UNAME" = Linux ] && [ "$IFACE" != lo ]; then
 		need sysfs
 		after modules
 	fi
@@ -54,14 +55,14 @@ depend()
 	esac
 
 	if [ "$(command -v "depend_${IFVAR}")" = "depend_${IFVAR}" ]; then
-		depend_${IFVAR}
+		"depend_${IFVAR}"
 	fi
 
-	local dep= prov=
+	local dep prov
 	for dep in need use before after provide keyword; do
 		eval prov=\$rc_${dep}_${IFVAR}
 		if [ -n "${prov}" ]; then
-			${dep} ${prov}
+			"${dep}" "${prov}"
 			ewarn "rc_${dep}_${IFVAR} is deprecated."
 			ewarn "Please use rc_net_${IFVAR}_${dep} instead."
 		fi


             reply	other threads:[~2019-04-21  5:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21  5:34 Robin H. Johnson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-01-07  9:42 [gentoo-commits] proj/netifrc:master commit in: init.d/ Sam James
2021-03-31  1:11 Patrick McLean
2020-09-07 13:03 Lars Wendler
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2019-04-21  5:34 Robin H. Johnson
2017-11-14 20:48 Robin H. Johnson
2017-11-14 20:48 Robin H. Johnson
2016-10-24 20:52 Robin H. Johnson
2016-10-24  0:23 Robin H. Johnson
2016-10-24  0:23 Robin H. Johnson
2016-10-23 23:50 Robin H. Johnson
2016-07-05 18:13 Robin H. Johnson
2015-11-08 14:30 Robin H. Johnson
2015-11-08 14:30 Robin H. Johnson
2015-05-25 10:04 Mike Frysinger
2015-05-25 10:01 Mike Frysinger
2015-01-09 17:17 Robin H. Johnson
2014-10-11 19:47 Robin H. Johnson
2014-07-17 17:56 Robin H. Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1555824731.abcc0bd4c372e36cc6e5e46832e7664a72b6bcaa.robbat2@OpenRC \
    --to=robbat2@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox