public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Zac Medico" <zmedico@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/portage:master commit in: pym/portage/util/_eventloop/
Date: Wed, 18 Jul 2018 03:41:00 +0000 (UTC)	[thread overview]
Message-ID: <1531885205.a7c7af98d755f34e84d1f0f847e2c0d5cc5b7e2f.zmedico@gentoo> (raw)

commit:     a7c7af98d755f34e84d1f0f847e2c0d5cc5b7e2f
Author:     Zac Medico <zmedico <AT> gentoo <DOT> org>
AuthorDate: Wed Jul 18 03:36:59 2018 +0000
Commit:     Zac Medico <zmedico <AT> gentoo <DOT> org>
CommitDate: Wed Jul 18 03:40:05 2018 +0000
URL:        https://gitweb.gentoo.org/proj/portage.git/commit/?id=a7c7af98

EventLoop: raise TypeError for unexpected call_* keyword args

 pym/portage/util/_eventloop/EventLoop.py | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/pym/portage/util/_eventloop/EventLoop.py b/pym/portage/util/_eventloop/EventLoop.py
index 084ff0c18..ffd12cff9 100644
--- a/pym/portage/util/_eventloop/EventLoop.py
+++ b/pym/portage/util/_eventloop/EventLoop.py
@@ -859,11 +859,23 @@ class EventLoop(object):
 		@return: a handle which can be used to cancel the callback
 		@rtype: asyncio.Handle (or compatible)
 		"""
+		try:
+			unexpected = next(key for key in kwargs if key != 'context')
+		except StopIteration:
+			pass
+		else:
+			raise TypeError("call_soon() got an unexpected keyword argument '%s'" % unexpected)
 		return self._handle(self._idle_add(
 			self._call_soon_callback(callback, args)), self)
 
 	def call_soon_threadsafe(self, callback, *args, **kwargs):
 		"""Like call_soon(), but thread safe."""
+		try:
+			unexpected = next(key for key in kwargs if key != 'context')
+		except StopIteration:
+			pass
+		else:
+			raise TypeError("call_soon_threadsafe() got an unexpected keyword argument '%s'" % unexpected)
 		# idle_add provides thread safety
 		return self._handle(self.idle_add(
 			self._call_soon_callback(callback, args)), self)
@@ -909,6 +921,12 @@ class EventLoop(object):
 		@return: a handle which can be used to cancel the callback
 		@rtype: asyncio.Handle (or compatible)
 		"""
+		try:
+			unexpected = next(key for key in kwargs if key != 'context')
+		except StopIteration:
+			pass
+		else:
+			raise TypeError("call_later() got an unexpected keyword argument '%s'" % unexpected)
 		return self._handle(self.timeout_add(
 			delay * 1000, self._call_soon_callback(callback, args)), self)
 
@@ -936,6 +954,12 @@ class EventLoop(object):
 		@return: a handle which can be used to cancel the callback
 		@rtype: asyncio.Handle (or compatible)
 		"""
+		try:
+			unexpected = next(key for key in kwargs if key != 'context')
+		except StopIteration:
+			pass
+		else:
+			raise TypeError("call_at() got an unexpected keyword argument '%s'" % unexpected)
 		delta = when - self.time()
 		return self.call_later(delta if delta > 0 else 0, callback, *args)
 


             reply	other threads:[~2018-07-18  3:41 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  3:41 Zac Medico [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-17 19:27 [gentoo-commits] proj/portage:master commit in: pym/portage/util/_eventloop/ Zac Medico
2018-07-17 19:07 Zac Medico
2018-06-27  3:05 Zac Medico
2018-05-26 20:22 Zac Medico
2018-05-25  3:15 Zac Medico
2018-05-13 16:58 Zac Medico
2018-05-07  0:27 Zac Medico
2018-04-19  6:41 Zac Medico
2018-04-19  6:16 Zac Medico
2018-04-18 21:52 Zac Medico
2018-04-17 18:24 Zac Medico
2018-04-17 18:02 Zac Medico
2018-04-17  6:24 Zac Medico
2018-04-17  0:53 Zac Medico
2018-04-16  8:48 Zac Medico
2018-04-16  6:43 Zac Medico
2018-04-16  0:03 Zac Medico
2018-04-15 22:32 Zac Medico
2018-04-09  1:27 Zac Medico
2018-04-08 22:08 Zac Medico
2018-04-08 21:37 Zac Medico
2018-04-08 21:18 Zac Medico
2018-04-07 20:20 Zac Medico
2017-05-05 18:47 Zac Medico
2013-02-25 23:53 Zac Medico
2013-01-04  3:39 Zac Medico
2012-12-31  3:16 Zac Medico
2012-12-28  1:44 Zac Medico
2012-12-28  1:36 Zac Medico
2012-12-27  2:39 Zac Medico
2012-12-27  2:31 Zac Medico
2012-11-22 12:23 Zac Medico
2012-09-26  2:26 Zac Medico
2012-08-22 16:23 Zac Medico
2012-08-22  5:39 Zac Medico
2012-02-18  4:04 Zac Medico
2012-02-17 23:23 Zac Medico
2012-02-17 22:17 Zac Medico
2012-02-17 10:31 Zac Medico
2012-02-17 10:20 Zac Medico
2012-02-17  9:29 Zac Medico
2012-02-17  6:29 Zac Medico
2012-02-17  6:04 Zac Medico
2012-02-17  3:08 Zac Medico
2012-02-16 21:43 Zac Medico
2012-02-16 21:35 Zac Medico
2012-02-16  4:58 Zac Medico
2012-02-16  4:41 Zac Medico
2012-02-14 16:27 Zac Medico
2012-02-14  3:06 Zac Medico
2012-02-14  1:23 Zac Medico
2012-02-11 23:56 Zac Medico
2012-02-11 21:41 Zac Medico
2012-02-11 21:11 Zac Medico
2012-02-11 19:35 Zac Medico
2012-02-11  2:59 Zac Medico
2012-02-10  0:42 Zac Medico
2012-02-10  0:20 Zac Medico
2012-02-10  0:17 Zac Medico
2012-02-09  7:25 Zac Medico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1531885205.a7c7af98d755f34e84d1f0f847e2c0d5cc5b7e2f.zmedico@gentoo \
    --to=zmedico@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox