public inbox for gentoo-commits@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Tim Harder" <radhermit@gentoo.org>
To: gentoo-commits@lists.gentoo.org
Subject: [gentoo-commits] proj/zsh-completion:master commit in: src/
Date: Mon,  1 Dec 2014 07:48:43 +0000 (UTC)	[thread overview]
Message-ID: <1417420116.bde2bd3191812eddac0fab246d85bbb3e75e2a2c.radhermit@gentoo> (raw)

commit:     bde2bd3191812eddac0fab246d85bbb3e75e2a2c
Author:     Tim Harder <radhermit <AT> gentoo <DOT> org>
AuthorDate: Mon Dec  1 07:39:35 2014 +0000
Commit:     Tim Harder <radhermit <AT> gentoo <DOT> org>
CommitDate: Mon Dec  1 07:48:36 2014 +0000
URL:        http://sources.gentoo.org/gitweb/?p=proj/zsh-completion.git;a=commit;h=bde2bd31

_gentoo_packages: more stylistic consistency

Generally we keep lvalues and rvalues in consistent positions in
conditional checks even though they can be swapped around there.

---
 src/_gentoo_packages | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/_gentoo_packages b/src/_gentoo_packages
index a8a3aff..2bfa8c4 100644
--- a/src/_gentoo_packages
+++ b/src/_gentoo_packages
@@ -11,7 +11,7 @@ _portdir() {
     local mainreponame mainrepopath overlayname overlaypath
 
     if [[ -e /usr/share/portage/config/repos.conf ]]; then
-        if [[ ${1} == -o ]]; then
+        if [[ ${1} == "-o" ]]; then
             for overlayname in $(_parsereposconf -l); do
                 overlaypath+=($(_parsereposconf ${overlayname} location))
             done
@@ -33,7 +33,7 @@ _portdir() {
         source /etc/make.conf 2>/dev/null
         source /etc/portage/make.conf 2>/dev/null
 
-        if [[ "-o" == ${1} ]]; then
+        if [[ ${1} == "-o" ]]; then
             echo "${(@u)PORTDIR_OVERLAY}"
         else
             echo "${PORTDIR}"
@@ -76,7 +76,7 @@ _parsereposconf() {
         done < ${f}
     done
 
-    if [[ "-l" == ${1} ]]; then
+    if [[ ${1} == "-l" ]]; then
         echo "${(@)secname}"
     else
         echo "${v}"
@@ -110,13 +110,13 @@ _parsesetsconf() {
                 arr[${name}]=${value}
 
                 if [[ ${insection} == 1 && ${name} == "section" ]]; then
-                    [[ "sets" == ${2} ]] && [[ ! ${value} =~ "sets" ]] && sections+=(${value})
+                    [[ ${2} == "sets" ]] && [[ ! ${value} =~ "sets" ]] && sections+=(${value})
                     insection=0
                 elif [[ ${name} == "section" ]]; then
                     [[ ${value} =~ "${1:t} sets" ]] && insection=1
-                    [[ "sets" == ${2} ]] && [[ ! ${value} =~ "sets" ]] && sections+=(${value})
+                    [[ ${2} == "sets" ]] && [[ ! ${value} =~ "sets" ]] && sections+=(${value})
                 elif [[ ${insection} == 1 ]]; then
-                    [[ "sets" == ${2} ]] && continue
+                    [[ ${2} == "sets" ]] && continue
                     if [[ ${name} == "directory" ]]; then
                         v=${value}
                     fi
@@ -126,7 +126,7 @@ _parsesetsconf() {
         fi
     done
 
-    if [[ "sets" == ${2} ]]; then
+    if [[ ${2} == "sets" ]]; then
         [[ ((${#sections} > 0)) ]] && echo ${(@)sections}
     else
         [[ ((${#v} > 0)) ]] && echo ${v:t}


             reply	other threads:[~2014-12-01  7:48 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01  7:48 Tim Harder [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-08 19:25 [gentoo-commits] proj/zsh-completion:master commit in: src/ Mike Gilbert
2023-01-17 14:45 Vadim Misbakh-Soloviov
2022-01-12  9:35 Vadim Misbakh-Soloviov
2022-01-12  9:35 Vadim Misbakh-Soloviov
2020-09-14  3:13 Vadim Misbakh-Soloviov
2020-09-14  3:13 Vadim Misbakh-Soloviov
2020-09-14  3:13 Vadim Misbakh-Soloviov
2020-09-14  3:13 Vadim Misbakh-Soloviov
2020-02-19 18:51 Vadim Misbakh-Soloviov
2020-02-19 18:47 Vadim Misbakh-Soloviov
2020-02-19 18:47 Vadim Misbakh-Soloviov
2020-02-19 18:47 Vadim Misbakh-Soloviov
2020-02-19 18:47 Vadim Misbakh-Soloviov
2020-02-19 18:47 Vadim Misbakh-Soloviov
2020-02-19 17:53 Vadim Misbakh-Soloviov
2020-02-19 17:53 Vadim Misbakh-Soloviov
2020-02-19 17:53 Vadim Misbakh-Soloviov
2015-04-28 14:56 Vadim A. Misbakh-Soloviov
2015-04-28 12:07 Vadim A. Misbakh-Soloviov
2015-04-28 12:07 Vadim A. Misbakh-Soloviov
2014-12-22 22:57 Tim Harder
2014-12-21  9:51 Tim Harder
2014-12-21  9:51 Tim Harder
2014-12-20 23:22 Tim Harder
2014-12-20 22:29 Tim Harder
2014-12-20 20:04 Tim Harder
2014-12-20 20:04 Tim Harder
2014-12-20 20:04 Tim Harder
2014-12-20  5:31 Tim Harder
2014-12-20  4:54 Tim Harder
2014-12-20  4:39 Tim Harder
2014-12-20  4:39 Tim Harder
2014-12-20  3:21 Tim Harder
2014-12-20  3:08 Tim Harder
2014-12-20  3:08 Tim Harder
2014-12-20  3:08 Tim Harder
2014-12-20  2:35 Tim Harder
2014-12-20  2:15 Tim Harder
2014-12-20  2:15 Tim Harder
2014-12-18 16:59 Tim Harder
2014-12-18 16:59 Tim Harder
2014-12-18 16:59 Tim Harder
2014-12-01  7:48 Tim Harder
2014-12-01  7:34 Tim Harder
2014-12-01  7:34 Tim Harder
2014-11-27  7:23 Tim Harder
2014-11-27  7:23 Tim Harder
2014-11-27  6:39 Tim Harder
2014-11-24  9:13 Vadim A. Misbakh-Soloviov
2014-11-24  7:33 Tim Harder
2014-11-24  7:33 Tim Harder
2014-11-23 21:35 Vadim A. Misbakh-Soloviov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417420116.bde2bd3191812eddac0fab246d85bbb3e75e2a2c.radhermit@gentoo \
    --to=radhermit@gentoo.org \
    --cc=gentoo-commits@lists.gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox