From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums
Date: Fri, 08 Sep 2023 12:06:43 +0200 [thread overview]
Message-ID: <116a7ea57082ce953fe0b184c175be2042b230bb.camel@gentoo.org> (raw)
In-Reply-To: <d9ab2b383e69e171280483bd731c3fb09e677c1b.camel@gentoo.org>
On Fri, 2023-09-08 at 12:03 +0200, Michał Górny wrote:
> On Mon, 2023-09-04 at 08:42 +0200, Ulrich Mueller wrote:
> > > > > > > On Mon, 04 Sep 2023, Michał Górny wrote:
> >
> > > --- a/eclass/verify-sig.eclass
> > > +++ b/eclass/verify-sig.eclass
> > > @@ -214,12 +214,15 @@ verify-sig_verify_message() {
> > > }
> >
> >
> >
> >
> > > # @FUNCTION: verify-sig_verify_unsigned_checksums
> > > -# @USAGE: <checksum-file> <algo> <files>
> > > +# @USAGE: <checksum-file> <format> <files>
> >
> > Below, verify-sig_verify_signed_checksums() still says "algo", change
> > that too for consistency?
>
> If I must.
>
> >
> > > # @DESCRIPTION:
> > > # Verify the checksums for all files listed in the space-separated list
> > > -# <files> (akin to ${A}) using a <checksum-file>. <algo> specifies
> > > -# the checksum algorithm (e.g. sha256). <checksum-file> can be "-"
> > > -# for stdin.
> > > +# <files> (akin to ${A}) using a <checksum-file>. <format> specifies
> > > +# the checksum file format. <checksum-file> can be "-" for stdin.
> > > +#
> > > +# The following formats are supported:
> > > +# - sha256 -- sha256sum (<hash> <filename>)
> > > +# - openssl-dgst -- openssl dgst (<algo>(<filename>)=<hash>)
> >
> > This won't be rendered as a list in the man page, but will be rewrapped
> > as a paragraph. (Putting a space before the "-" will help.)
> >
> > The existing variable documentation of VERIFY_SIG_METHOD suffers from
> > the same problem, BTW.
>
> Hmm, I can't get it to work with the space either. Whatever I do,
> eclass-to-manpage.awk seems to copy it verbatim.
>
Nevermind, now I see that it's meaningful to groff. For some reason, I
thought eclass-to-manpage will use some magical sequences.
--
Best regards,
Michał Górny
next prev parent reply other threads:[~2023-09-08 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 1:55 [gentoo-dev] [PATCH 0/3] verify-sig.eclass: `openssl dgst` format support Michał Górny
2023-09-04 1:55 ` [gentoo-dev] [PATCH 1/3] eclass/tests: Add initial tests for verify-sig Michał Górny
2023-09-04 1:55 ` [gentoo-dev] [PATCH 2/3] verify-sig.eclass: Support `openssl dgst` format checksums Michał Górny
2023-09-04 6:42 ` Ulrich Mueller
2023-09-08 10:03 ` Michał Górny
2023-09-08 10:06 ` Michał Górny [this message]
2023-09-08 13:06 ` Ulrich Mueller
2023-09-04 1:55 ` [gentoo-dev] [PATCH 3/3] verify-sig.eclass: Fix handling multiple/duplicate signatures Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=116a7ea57082ce953fe0b184c175be2042b230bb.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox