From: Stephan Hartmann <sultan@gentoo.org>
To: Ulrich Mueller <ulm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, chromium@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 3/3] chromium-2.eclass: enable EAPI 8
Date: Mon, 16 Aug 2021 18:47:22 +0200 [thread overview]
Message-ID: <06a96b8d-c1a2-b2b5-f09c-43ea4216aadc@googlemail.com> (raw)
In-Reply-To: <uv94anca9@gentoo.org>
On 8/12/21 1:16 PM, Ulrich Mueller wrote:
>
>> case ${EAPI} in
>> - 7) ;;
>> + 7|8) ;;
>> *) die "EAPI=${EAPI:-0} is not supported" ;;
>
> Nitpick: Add "${ECLASS}: " at the beginning of the die message.
Thanks. Fixed locally.
>
>> esac
prev parent reply other threads:[~2021-08-16 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-11 15:28 [gentoo-dev] [PATCH 0/3] Updates for chromium-2.eclass Stephan Hartmann
2021-08-11 15:28 ` [gentoo-dev] [PATCH 1/3] chromium-2.eclass: remove GYP support Stephan Hartmann
2021-08-11 15:28 ` [gentoo-dev] [PATCH 2/3] chromium-2.eclass: update documentation Stephan Hartmann
2021-08-11 15:28 ` [gentoo-dev] [PATCH 3/3] chromium-2.eclass: enable EAPI 8 Stephan Hartmann
2021-08-12 11:16 ` Ulrich Mueller
2021-08-16 16:47 ` Stephan Hartmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06a96b8d-c1a2-b2b5-f09c-43ea4216aadc@googlemail.com \
--to=sultan@gentoo.org \
--cc=chromium@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox