From: Joonas Niilola <juippis@gentoo.org>
To: gentoo-proxy-maint@lists.gentoo.org
Subject: Re: [gentoo-proxy-maint] [PATCH v4] net-nntp/tin: add 2.6.2
Date: Sat, 14 Jan 2023 11:55:03 +0200 [thread overview]
Message-ID: <01e16f18-aeca-2170-38a0-3110f95b1de3@gentoo.org> (raw)
In-Reply-To: <20230114094831.17557-1-cyber+gentoo@sysrq.in>
[-- Attachment #1.1: Type: text/plain, Size: 1259 bytes --]
On 14.1.2023 11.48, Anna Vyalkova wrote:
> In this update:
> * New: NNTPS support with different backends (openssl by default)
> * New: PCRE2 support (enabled by default)
> * Enable local news support
> * Add missing virtual/libiconv dependency
> * Add missing sys-devel/gettext bdep
> * Drop net-mail/metamail optfeature dep (treecleaned)
> * Export BUILD_* variables
>
Hey,
sorry that I failed to see this yesterday, but could we rework the whole
ssl logic in this ebuild? I just remembered we shouldn't use
REQUIRED_USE to choose an ssl implementation, but instead prioritize it
via use flag selection. See https://bugs.gentoo.org/781908. This was
better documented when libressl was around, and truthfully hasn't been
as much of a problem ever since libressl was removed.
So I'd suggest something like this:
RDEPEND="...
ssl? (
gnutls? ( net-libs/gnutls:= )
!gnutls (
libtls? ( dev-libs/libretls:= )
!libtls? ( dev-libs/openssl:= )
)
)
..."
src_configure() {
...
if use ssl; then
if use gnutls; then
myeconfargs+=( --with-nntps=gnutls )
elif ! use gnutls && use libtls; then
myeconfargs+=( --with-nntps=libtls )
else
myeconfargs+=( --with-nntps=openssl )
fi
fi
...
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 618 bytes --]
next prev parent reply other threads:[~2023-01-14 9:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-25 18:06 [gentoo-proxy-maint] [PATCH] net-nntp/tin: add 2.6.2 Anna Vyalkova
2023-01-12 10:32 ` [gentoo-proxy-maint] [PATCH v2] " Anna Vyalkova
2023-01-13 13:45 ` Joonas Niilola
2023-01-13 15:06 ` Anna (cybertailor) Vyalkova
2023-01-13 15:02 ` [gentoo-proxy-maint] [PATCH v3] " Anna Vyalkova
2023-01-14 9:48 ` [gentoo-proxy-maint] [PATCH v4] " Anna Vyalkova
2023-01-14 9:55 ` Joonas Niilola [this message]
2023-01-14 10:28 ` [gentoo-proxy-maint] [PATCH v5] " Anna Vyalkova
2023-01-14 18:07 ` Joonas Niilola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01e16f18-aeca-2170-38a0-3110f95b1de3@gentoo.org \
--to=juippis@gentoo.org \
--cc=gentoo-proxy-maint@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox