From: Georgy Yakovlev <gyakovlev@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7
Date: Sun, 03 Feb 2019 01:19:11 -0800 [thread overview]
Message-ID: <2515570.uiBT8cRAIA@reaper> (raw)
In-Reply-To: <20190203090117.032cd5f4@sf>
[-- Attachment #1: Type: text/plain, Size: 688 bytes --]
On Sunday, February 3, 2019 1:01:17 AM PST Sergei Trofimovich wrote:
> On Sat, 2 Feb 2019 21:27:29 -0800
>
> Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
> > Since D, ED, ROOT, EROOT no longer have a trailing slash in EAPI=7
> > This eclass is terribly broken, installing things into
> > imageusr/...
>
> ...
>
> > opam-installer -i \
> >
> > - --prefix="${ED}usr" \
> > + --prefix="${ED%/}usr" \
>
> Now this change strips '/' on older EAPIs as well. I guess you meant:
> --prefix="${ED%/}/usr" \
yeah, I missed that in the first version of the patch. second one is ok,
probably should have posted separately as a non-reply.
--
Georgy Yakovlev
Gentoo Linux Developer
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-02-03 9:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 5:27 [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7 Georgy Yakovlev
2019-02-03 5:35 ` [gentoo-dev] [PATCH] opam.eclass: check only for known EAPI, die otherwise Georgy Yakovlev
2019-02-03 5:40 ` [gentoo-dev] [PATCH 1/2] opam.eclass: unbreak on EAPI=7 Georgy Yakovlev
2019-02-03 5:40 ` [gentoo-dev] [PATCH 2/2] opam.eclass: check only for known EAPI, die otherwise Georgy Yakovlev
2019-02-03 9:01 ` [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7 Sergei Trofimovich
2019-02-03 9:19 ` Georgy Yakovlev [this message]
2019-02-04 10:52 ` Alexis Ballier
2019-02-04 21:42 ` Georgy Yakovlev
2019-02-05 10:21 ` Alexis Ballier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2515570.uiBT8cRAIA@reaper \
--to=gyakovlev@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox