From: Sergei Trofimovich <slyfox@gentoo.org>
To: Georgy Yakovlev <gyakovlev@gentoo.org>, gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7
Date: Sun, 3 Feb 2019 09:01:17 +0000 [thread overview]
Message-ID: <20190203090117.032cd5f4@sf> (raw)
In-Reply-To: <20190203052729.51024-1-gyakovlev@gentoo.org>
On Sat, 2 Feb 2019 21:27:29 -0800
Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
> Since D, ED, ROOT, EROOT no longer have a trailing slash in EAPI=7
> This eclass is terribly broken, installing things into
> imageusr/...
...
> opam-installer -i \
> - --prefix="${ED}usr" \
> + --prefix="${ED%/}usr" \
Now this change strips '/' on older EAPIs as well. I guess you meant:
--prefix="${ED%/}/usr" \
--
Sergei
next prev parent reply other threads:[~2019-02-03 9:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-03 5:27 [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7 Georgy Yakovlev
2019-02-03 5:35 ` [gentoo-dev] [PATCH] opam.eclass: check only for known EAPI, die otherwise Georgy Yakovlev
2019-02-03 5:40 ` [gentoo-dev] [PATCH 1/2] opam.eclass: unbreak on EAPI=7 Georgy Yakovlev
2019-02-03 5:40 ` [gentoo-dev] [PATCH 2/2] opam.eclass: check only for known EAPI, die otherwise Georgy Yakovlev
2019-02-03 9:01 ` Sergei Trofimovich [this message]
2019-02-03 9:19 ` [gentoo-dev] [PATCH] opam.eclass: unbreak on EAPI=7 Georgy Yakovlev
2019-02-04 10:52 ` Alexis Ballier
2019-02-04 21:42 ` Georgy Yakovlev
2019-02-05 10:21 ` Alexis Ballier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190203090117.032cd5f4@sf \
--to=slyfox@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=gyakovlev@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox